[
https://issues.apache.org/jira/browse/KAFKA-8614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bob Barrett updated KAFKA-8614:
-------------------------------
Description:
IncrementalAlterConfigsResponse and AlterConfigsResponse have an identical
structure for per-resource error codes, but in AlterConfigsResponse it is named
`Resources` while in IncrementalAlterConfigsResponse it is named `responses`.
AlterConfigsResponse:
{code:java}
{ "name": "Resources", "type": "[]AlterConfigsResourceResponse", "versions":
"0+", "about": "The responses for each resource.", "fields": [
{ "name": "ErrorCode", "type": "int16", "versions": "0+", "about": "The
resource error code." },
{ "name": "ErrorMessage", "type": "string", "nullableVersions": "0+",
"versions": "0+", "about": "The resource error message, or null if there was no
error." },
{ "name": "ResourceType", "type": "int8", "versions": "0+", "about": "The
resource type." },
{ "name": "ResourceName", "type": "string", "versions": "0+", "about": "The
resource name." }
]}{code}
IncrementalAlterConfigsResponse:
{code:java}
{ "name": "responses", "type": "[]AlterConfigsResourceResult", "versions":
"0+", "about": "The responses for each resource.", "fields": [
{ "name": "ErrorCode", "type": "int16", "versions": "0+", "about": "The
resource error code." },
{ "name": "ErrorMessage", "type": "string", "nullableVersions": "0+",
"versions": "0+", "about": "The resource error message, or null if there was no
error." },
{ "name": "ResourceType", "type": "int8", "versions": "0+", "about": "The
resource type." },
{ "name": "ResourceName", "type": "string", "versions": "0+", "about": "The
resource name." }
]}
{code}
We should change the field in IncrementalAlterConfigsResponse to be consistent
with AlterConfigsResponse.
was:
IncrementalAlterConfigsResponse and AlterConfigsResponse have an identical
structure for per-resource error codes, but in AlterConfigsResponse it is named
`Resources` while in IncrementalAlterConfigsResponse it is named `responses`.
AlterConfigsResponse:
{{{\{{ "name": "Resources", "type": "[]AlterConfigsResourceResponse",
"versions": "0+",}}}}
{{"about": "The responses for each resource.", "fields": [}}
{{ \{{{ "name": "ErrorCode", "type": "int16", "versions": "0+",}}}}
{{"about": "The resource error code." },}}
{{ \{{{ "name": "ErrorMessage", "type": "string", "nullableVersions": "0+",
"versions": "0+",}}}}
{{"about": "The resource error message, or null if there was no error." },}}
{{ \{{{ "name": "ResourceType", "type": "int8", "versions": "0+",}}}}
{{"about": "The resource type." },}}
{{ \{{{ "name": "ResourceName", "type": "string", "versions": "0+",}}}}
{{ \{{"about": "The resource name." }}}}}
IncrementalAlterConfigsResponse:
{{{\{ { "name": "responses", "type": "[]AlterConfigsResourceResult",
"versions": "0+",}}}}
{{ \{{ "about": "The responses for each resource.", "fields": [}}}}
{{ \{{ { "name": "ErrorCode", "type": "int16", "versions": "0+",}}}}
{{ \{{ "about": "The resource error code." },}}}}
{{ \{{ { "name": "ErrorMessage", "type": "string", "nullableVersions": "0+",
"versions": "0+",}}}}
{{ \{{ "about": "The resource error message, or null if there was no error."
},}}}}
{{ \{{ { "name": "ResourceType", "type": "int8", "versions": "0+",}}}}
{{ \{{ "about": "The resource type." },}}}}
{{ \{{ { "name": "ResourceName", "type": "string", "versions": "0+",}}}}
{{ \{{ "about": "The resource name." }}}}}
We should change the field in IncrementalAlterConfigsResponse to be consistent
with AlterConfigsResponse.
> Rename the `responses` field of IncrementalAlterConfigsResponse to match
> AlterConfigs
> -------------------------------------------------------------------------------------
>
> Key: KAFKA-8614
> URL: https://issues.apache.org/jira/browse/KAFKA-8614
> Project: Kafka
> Issue Type: Bug
> Components: clients
> Affects Versions: 2.3.0
> Reporter: Bob Barrett
> Priority: Minor
>
> IncrementalAlterConfigsResponse and AlterConfigsResponse have an identical
> structure for per-resource error codes, but in AlterConfigsResponse it is
> named `Resources` while in IncrementalAlterConfigsResponse it is named
> `responses`.
> AlterConfigsResponse:
> {code:java}
> { "name": "Resources", "type": "[]AlterConfigsResourceResponse", "versions":
> "0+", "about": "The responses for each resource.", "fields": [
> { "name": "ErrorCode", "type": "int16", "versions": "0+", "about": "The
> resource error code." },
> { "name": "ErrorMessage", "type": "string", "nullableVersions": "0+",
> "versions": "0+", "about": "The resource error message, or null if there was
> no error." },
> { "name": "ResourceType", "type": "int8", "versions": "0+", "about": "The
> resource type." },
> { "name": "ResourceName", "type": "string", "versions": "0+", "about":
> "The resource name." }
> ]}{code}
>
> IncrementalAlterConfigsResponse:
>
> {code:java}
> { "name": "responses", "type": "[]AlterConfigsResourceResult", "versions":
> "0+", "about": "The responses for each resource.", "fields": [
> { "name": "ErrorCode", "type": "int16", "versions": "0+", "about": "The
> resource error code." },
> { "name": "ErrorMessage", "type": "string", "nullableVersions": "0+",
> "versions": "0+", "about": "The resource error message, or null if there was
> no error." },
> { "name": "ResourceType", "type": "int8", "versions": "0+", "about": "The
> resource type." },
> { "name": "ResourceName", "type": "string", "versions": "0+", "about":
> "The resource name." }
> ]}
> {code}
> We should change the field in IncrementalAlterConfigsResponse to be
> consistent with AlterConfigsResponse.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
