[ 
https://issues.apache.org/jira/browse/KAFKA-1566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16895901#comment-16895901
 ] 

Sönke Liebau commented on KAFKA-1566:
-------------------------------------

Is this still something we are interested in doing?  I just closed KAFKA-1234 
as a duplicate of this, because it had no activity for even longer than this 
ticket.

Personally I think this is not really necessary, as most deployments will run 
from service runner tools like Upstart or Systemd which provide methods for 
setting environment variables. At the same time, it also won't hurt and might 
be useful for some people, so there is no real reason not to do it.

> Kafka environment configuration (kafka-env.sh)
> ----------------------------------------------
>
>                 Key: KAFKA-1566
>                 URL: https://issues.apache.org/jira/browse/KAFKA-1566
>             Project: Kafka
>          Issue Type: Improvement
>          Components: tools
>            Reporter: Cosmin Lehene
>            Assignee: Sriharsha Chintalapani
>            Priority: Major
>              Labels: newbie, windows
>         Attachments: KAFKA-1566.patch, KAFKA-1566_2015-02-21_21:57:02.patch, 
> KAFKA-1566_2015-03-17_17:01:38.patch, KAFKA-1566_2015-03-17_17:19:23.patch
>
>
> It would be useful (especially for automated deployments) to have an 
> environment configuration file that could be sourced from the launcher files 
> (e.g. kafka-run-server.sh). 
> This is how this could look like kafka-env.sh 
> {code}
> export KAFKA_JVM_PERFORMANCE_OPTS="-XX:+UseCompressedOops 
> -XX:+DisableExplicitGC -Djava.awt.headless=true \ -XX:+UseG1GC 
> -XX:PermSize=48m -XX:MaxPermSize=48m -XX:MaxGCPauseMillis=20 
> -XX:InitiatingHeapOccupancyPercent=35' %>" 
> export KAFKA_HEAP_OPTS="'-Xmx1G -Xms1G' %>" 
> export KAFKA_LOG4J_OPTS="-Dkafka.logs.dir=/var/log/kafka" 
> {code} 
> kafka-server-start.sh 
> {code} 
> ... 
> source $base_dir/config/kafka-env.sh 
> ... 
> {code} 
> This approach is consistent with Hadoop and HBase. However the idea here is 
> to be able to set these values in a single place without having to edit 
> startup scripts.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Reply via email to