[ 
https://issues.apache.org/jira/browse/KAFKA-8875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16923081#comment-16923081
 ] 

ASF GitHub Bot commented on KAFKA-8875:
---------------------------------------

huxihx commented on pull request #7298: KAFKA-8875:CreateTopic API should check 
topic existence before replic…
URL: https://github.com/apache/kafka/pull/7298
 
 
   …ation factor
   
   https://issues.apache.org/jira/browse/KAFKA-8875
   
   If the topic already exists, `handleCreateTopicsRequest` should return 
TopicExistsException even given an invalid config (replication factor for 
instance).
   
   *More detailed description of your change,
   if necessary. The PR title and PR message become
   the squashed commit message, so use a separate
   comment to ping reviewers.*
   
   *Summary of testing strategy (including rationale)
   for the feature or bug fix. Unit and/or integration
   tests are expected for any behaviour change and
   system tests should be considered for larger changes.*
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> CreateTopic API should check topic existence before replication factor
> ----------------------------------------------------------------------
>
>                 Key: KAFKA-8875
>                 URL: https://issues.apache.org/jira/browse/KAFKA-8875
>             Project: Kafka
>          Issue Type: Bug
>            Reporter: Jason Gustafson
>            Assignee: huxihx
>            Priority: Major
>
> If you try to create a topic and the replication factor cannot be satisfied, 
> Kafka will return `INVALID_REPLICATION_FACTOR`. If the topic already exists, 
> we should probably return `TOPIC_ALREADY_EXISTS` instead. You won't see this 
> problem if using TopicCommand because we check existence prior to creating 
> the topic.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

Reply via email to