[ https://issues.apache.org/jira/browse/KAFKA-8747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16926806#comment-16926806 ]
ASF GitHub Bot commented on KAFKA-8747: --------------------------------------- stanislavkozlovski commented on pull request #7320: KAFKA-8747: Fix the flaky ControllerEventManagerTest#testEventQueueTimeQuery test URL: https://github.com/apache/kafka/pull/7320 This patch adds retry functionality to the testEventQueueTime test assertion The test has been flaky, presumably due to some race condition with Yammer's JMX reporter and when the tested histogram metric gets updated. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Flaky Test ControllerEventManagerTest#testEventQueueTime > -------------------------------------------------------- > > Key: KAFKA-8747 > URL: https://issues.apache.org/jira/browse/KAFKA-8747 > Project: Kafka > Issue Type: Bug > Components: core, unit tests > Affects Versions: 2.4.0 > Reporter: Matthias J. Sax > Priority: Critical > Labels: flaky-test > > [https://builds.apache.org/job/kafka-pr-jdk11-scala2.12/6671/testReport/junit/kafka.controller/ControllerEventManagerTest/testEventQueueTime/] > {quote}java.lang.AssertionError: expected:<500.0> but was:<0.0> at > org.junit.Assert.fail(Assert.java:89) at > org.junit.Assert.failNotEquals(Assert.java:835) at > org.junit.Assert.assertEquals(Assert.java:555) at > org.junit.Assert.assertEquals(Assert.java:685) at > kafka.controller.ControllerEventManagerTest.testEventQueueTime(ControllerEventManagerTest.scala:100){quote} > STDOUT: > {quote}[2019-08-01 18:51:09,815] ERROR [ControllerEventThread controllerId=0] > Uncaught error processing event BrokerChange > (kafka.controller.ControllerEventManager$ControllerEventThread:76) > java.lang.NullPointerException at > kafka.controller.ControllerEventManagerTest.$anonfun$testEventThatThrowsException$1(ControllerEventManagerTest.scala:112) > at scala.Function0.apply$mcV$sp(Function0.scala:39) at > kafka.controller.ControllerEventManagerTest$$anon$3.process(ControllerEventManagerTest.scala:126) > at kafka.controller.QueuedEvent.process(ControllerEventManager.scala:53) at > kafka.controller.ControllerEventManager$ControllerEventThread.$anonfun$doWork$1(ControllerEventManager.scala:137) > at scala.runtime.java8.JFunction0$mcV$sp.apply(JFunction0$mcV$sp.java:23) at > kafka.metrics.KafkaTimer.time(KafkaTimer.scala:31) at > kafka.controller.ControllerEventManager$ControllerEventThread.doWork(ControllerEventManager.scala:137) > at kafka.utils.ShutdownableThread.run(ShutdownableThread.scala:89) > {quote} -- This message was sent by Atlassian Jira (v8.3.2#803003)