[ 
https://issues.apache.org/jira/browse/KAFKA-8834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16934418#comment-16934418
 ] 

Viktor Somogyi-Vass edited comment on KAFKA-8834 at 9/20/19 1:55 PM:
---------------------------------------------------------------------

I think I was referring to a metric that "it took 45 minutes to do the 
replication for the slowest partition". However now thinking about it I don't 
know if that makes too much sense.
Anyway, I proceeded with the other one, so the max offset lag. However I found 
that another good place for it is the ReplicaFetcherManager instead of the 
ReplicaManager but I'm hesitating on this one (because a MaxLag metric is 
already available there and it's similar but applied on all replication).
I'll probably be ready with the PR sometime next week so we can discuss this on 
the review.


was (Author: viktorsomogyi):
I think I was referring to a metric that "it took 45 minutes to do the 
replication for the slowest partition". However now thinking about it I don't 
know if that makes too much sense.
Anyway, I proceeded with the other one, so the max offset lag. However I found 
that the best place for it is the ReplicaFetcherManager instead of the 
ReplicaManager but I'm hesitating on this one (because a MaxLag metric is 
already available there and it's similar but applied on all replication).
I'll probably be ready with the PR sometime next week so we can discuss this on 
the review.

> Distinguish URPs caused by reassignment plus other metrics
> ----------------------------------------------------------
>
>                 Key: KAFKA-8834
>                 URL: https://issues.apache.org/jira/browse/KAFKA-8834
>             Project: Kafka
>          Issue Type: Improvement
>            Reporter: Jason Gustafson
>            Assignee: Viktor Somogyi-Vass
>            Priority: Major
>
> This Jira tracks implementation of KIP-352: 
> [https://cwiki.apache.org/confluence/display/KAFKA/KIP-352%3A+Distinguish+URPs+caused+by+reassignment].



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to