[ https://issues.apache.org/jira/browse/KAFKA-8954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16939495#comment-16939495 ]
ASF GitHub Bot commented on KAFKA-8954: --------------------------------------- dajac commented on pull request #7406: KAFKA-8954; Topic existence check is wrongly implemented in the DeleteOffset API URL: https://github.com/apache/kafka/pull/7406 This patch changes the way topic existence is checked in the DeleteOffset API. Previously, it was relying on the committed offsets. Now, it relies on the metadata cache which is better. *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testing strategy (including rationale) for the feature or bug fix. Unit and/or integration tests are expected for any behaviour change and system tests should be considered for larger changes.* ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Topic existence check is wrongly implemented in the DeleteOffset API > -------------------------------------------------------------------- > > Key: KAFKA-8954 > URL: https://issues.apache.org/jira/browse/KAFKA-8954 > Project: Kafka > Issue Type: Improvement > Reporter: David Jacot > Assignee: David Jacot > Priority: Major > > The current DeleteOffset API check relies on the consumer group's committed > offsets to decide if a topic exists or not. While this works in most of the > cases, it does not work when a topic exists but it does not have any > committed offsets yet. Moreover, it is not consistent with other APIs which > rely on the metadata cache so it must be updated. -- This message was sent by Atlassian Jira (v8.3.4#803005)