[ https://issues.apache.org/jira/browse/KAFKA-8958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16947124#comment-16947124 ]
Matthias J. Sax commented on KAFKA-8958: ---------------------------------------- Yes, all those operator may get the Serdes from an upstream operator, and hence, all JavaDocs should be updated accordingly. > Fix Kafka Streams JavaDocs with regard to used Serdes > ----------------------------------------------------- > > Key: KAFKA-8958 > URL: https://issues.apache.org/jira/browse/KAFKA-8958 > Project: Kafka > Issue Type: Improvement > Components: streams > Reporter: Matthias J. Sax > Assignee: bibin sebastian > Priority: Minor > Labels: beginner, newbie > > In older released, Kafka Streams applied operator specific overwrites of > Serdes as in-place overwrites. In newer releases, Kafka Streams tries to > re-use Serdes more "aggressively" by pushing serde information downstream if > the key and/or value did not change. > However, we never updated the JavaDocs accordingly. For example > `KStream#through(String topic)` JavaDocs say: > {code:java} > Materialize this stream to a topic and creates a new {@code KStream} from the > topic using default serializers, deserializers, and producer's {@link > DefaultPartitioner}. > {code} > The JavaDocs don't put into account that Serdes might have been set further > upstream, and the defaults from the config would not be used. > `KStream#through()` is just one example. We should address this through all > JavaDocs over all operators (ie, KStream, KGroupedStream, > TimeWindowedKStream, SessionWindowedKStream, KTable, and KGroupedTable. -- This message was sent by Atlassian Jira (v8.3.4#803005)