[ 
https://issues.apache.org/jira/browse/KAFKA-9094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16958784#comment-16958784
 ] 

ASF GitHub Bot commented on KAFKA-9094:
---------------------------------------

stanislavkozlovski commented on pull request #7591: KAFKA-9094: Add server-side 
replica validation for ZK triggered reassignments
URL: https://github.com/apache/kafka/pull/7591
 
 
   This patch adds the same server-side validation we use for API triggered 
reassignments to the ZK path.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Validate the replicas for partition reassignments triggered through the 
> /admin/reassign_partitions zNode
> --------------------------------------------------------------------------------------------------------
>
>                 Key: KAFKA-9094
>                 URL: https://issues.apache.org/jira/browse/KAFKA-9094
>             Project: Kafka
>          Issue Type: Improvement
>            Reporter: Stanislav Kozlovski
>            Assignee: Stanislav Kozlovski
>            Priority: Minor
>
> As was mentioned by [~jsancio] in 
> [https://github.com/apache/kafka/pull/7574#discussion_r337621762] , it would 
> make sense to apply the same replica validation we apply to the KIP-455 
> reassignments API.
> Namely, validate that the replicas:
> * are not empty (e.g [])
> * are not negative negative (e.g [1,2,-1])
> * are not brokers that are not part of the cluster or otherwise unhealthy 
> (e.g not in /brokers zNode)
> The last liveness validation is subject to comments. We are re-evaluating 
> whether we want to enforce it for the API



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to