[
https://issues.apache.org/jira/browse/KAFKA-9291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16993636#comment-16993636
]
ASF GitHub Bot commented on KAFKA-9291:
---------------------------------------
dengziming commented on pull request #7817: KAFKA-9291:revert the code of
KAFKA-9288 which bring fatal bug
URL: https://github.com/apache/kafka/pull/7817
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> error starting consumer
> -----------------------
>
> Key: KAFKA-9291
> URL: https://issues.apache.org/jira/browse/KAFKA-9291
> Project: Kafka
> Issue Type: Bug
> Reporter: dengziming
> Assignee: dengziming
> Priority: Blocker
> Attachments: image-2019-12-11-19-23-04-499.png,
> image-2019-12-11-19-28-29-559.png, image-2019-12-11-19-29-28-156.png,
> image-2019-12-11-19-29-53-353.png
>
>
> KAFKA-9288 add some code which I didn't now fully understand, but it indeed
> bring some bug which is serious and I debugged the process:
> 1. when consumer client start, an `ApiVersionsRequest` are send
> 2. KafkaApis. handleApiVersionsRequest(request) are invoke
> 3. ApiVersionsResponse.createApiVersionsResponse()
> 4. and it will add all `ApiVersionsResponseKey` to
> `ApiVersionsResponseKeyCollection`
> 5. every time add an element will return false! ( *this is where the bug is*,
> but I didn't find the reason)
> !image-2019-12-11-19-23-04-499.png!
>
> 6. after the for loop, the `ApiVersionsResponseKeyCollection` is EMPTY!
> !image-2019-12-11-19-28-29-559.png!
>
> 7. when the Client receive the response, ERROR will occur.
> !image-2019-12-11-19-29-28-156.png!
>
> 8. and my application was terminated
> !image-2019-12-11-19-29-53-353.png!
>
> So we can conclude that the reason is the new code of KAFKA-9288 in
> ApiVersionsResponseKeyCollection
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
