[ 
https://issues.apache.org/jira/browse/KAFKA-9243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16998703#comment-16998703
 ] 

Matthias J. Sax commented on KAFKA-9243:
----------------------------------------

The KTable JavaDocs you mentioned should be updated.

Another example is: 
[https://github.com/apache/kafka/blob/trunk/streams/src/main/java/org/apache/kafka/streams/kstream/KGroupedStream.java#L114-L122]

There are multiple methods on `KGroupedStream`, also `TimeWindowedKStream` and 
`SessionWindowedKStream` (and corresponding `Cogrouped...` classes) that all 
describe how state can be queried and we should update all of them.

Does this help?

Feel free to start with a single smaller PR to update `KTable` JavaDocs and you 
can follow up with more PRs for other classes. (It's easier to do multiple 
smaller PRs to get them reviewed and merged quicker).

> Update the javadocs from KeyValueStore to TimestampKeyValueStore
> ----------------------------------------------------------------
>
>                 Key: KAFKA-9243
>                 URL: https://issues.apache.org/jira/browse/KAFKA-9243
>             Project: Kafka
>          Issue Type: Improvement
>          Components: streams
>    Affects Versions: 2.3.0
>            Reporter: Walker Carlson
>            Assignee: Demitri Swan
>            Priority: Minor
>              Labels: beginner, newbie
>
> As of version 2.3, the DSL uses `TimestampedStores` to represent KTables. 
> However, the JavaDocs of all table-related operators still refer to plain 
> `KeyValueStores` etc instead of `TimestampedKeyValueStore` etc. Hence, all 
> those JavaDocs should be updated (the JavaDocs are technically not incorrect, 
> because one can access a TimestampedKeyValueStore as a KeyValueStore, too – 
> hence this ticket is not a "bug" but an improvement.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to