[
https://issues.apache.org/jira/browse/KAFKA-9314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17000339#comment-17000339
]
ASF GitHub Bot commented on KAFKA-9314:
---------------------------------------
ncliang commented on pull request #7857: KAFKA-9314: Apply
RetryWithToleranceOperator to push() and poll()
URL: https://github.com/apache/kafka/pull/7857
This commit applies RetryWithToleranceOperator added as part of KIP-298 to be
used when retrying RetriableExceptions thrown from SinkTask::put() and
SourceTask::poll().
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Connect put() and poll() retries not conforming to KIP-298
> ----------------------------------------------------------
>
> Key: KAFKA-9314
> URL: https://issues.apache.org/jira/browse/KAFKA-9314
> Project: Kafka
> Issue Type: Bug
> Components: KafkaConnect
> Reporter: Nigel Liang
> Assignee: Nigel Liang
> Priority: Major
>
> KIP-298 outlines the retry policy of Connect when errors are encountered. In
> particular, it proposes to retry on {{RetriableException}} on put() in
> SinkTask and poll() in SourceTask.
> However, the code does not reflect this change. For instance,
> WorkerSourceTask handles {{RetriableException}} thrown from {{poll()}} by
> entering into a tight retry loop without backoff. This has led to connectors
> having to workaround by simply not retrying and failing the task always.
> Users would need to manually restart the task to recover from even simple
> network glitches.
> AFAICT from reading code, the same is true for {{WorkerSinkTask}} when
> calling {{put()}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
