[
https://issues.apache.org/jira/browse/KAFKA-7785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17009702#comment-17009702
]
ASF GitHub Bot commented on KAFKA-7785:
---------------------------------------
highluck commented on pull request #7902: KAFKA-7785 Default partition grouper
to internal
URL: https://github.com/apache/kafka/pull/7902
Default partition grouper moved to interanl packege
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.*
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Remove PartitionGrouper interface and it's config and move
> DefaultPartitionGrouper to internal package
> ------------------------------------------------------------------------------------------------------
>
> Key: KAFKA-7785
> URL: https://issues.apache.org/jira/browse/KAFKA-7785
> Project: Kafka
> Issue Type: Improvement
> Components: streams
> Affects Versions: 2.1.0
> Reporter: Jacek Laskowski
> Priority: Blocker
> Fix For: 3.0.0
>
>
> Since {{DefaultPartitionGrouper}} is only for the purpose of the internal
> {{StreamsPartitionAssignor}} it would make sense to have it in the
> {{org.apache.kafka.streams.processor.internals}} package.
> I would also vote to move {{PartitionGrouper.}}
> Via KAFKA-8927 we deprecated the `PartitionGrouper` interface in 2.4 release
> – this allows us to remove the public interface and its corresponding config
> in the next major release (ie, 3.0.0). `DefaultPartitionGrouper` was
> implicitly deprecated via KAFKA-8927.
> Hence, we can move the interface as well as the default implementation into
> an internal package (or maybe just remove the interface completely as there
> are no plans to support multiple implementations atm).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
