[ 
https://issues.apache.org/jira/browse/KAFKA-9622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17047300#comment-17047300
 ] 

Konstantine Karantasis commented on KAFKA-9622:
-----------------------------------------------

Indeed, Connect uses Jetty for its REST API. 
Maybe a test that would verify proper shutdown of the Jetty server wouldn't be 
a bad idea, as long as it runs dependably.

Do you have any logs or evidence on how this error would surface with Jetty in 
Connect [~rigelbm]? It would be good to know whether a test case fits better 
with our integration tests or the system tests. Also, if you'd be interested to 
submit a PR with such a test I'd be happy to assign this Jira ticket to you. 

> Improve tests to detect post-processing failures in Jetty request handling.
> ---------------------------------------------------------------------------
>
>                 Key: KAFKA-9622
>                 URL: https://issues.apache.org/jira/browse/KAFKA-9622
>             Project: Kafka
>          Issue Type: Test
>            Reporter: Rigel Bezerra de Melo
>            Priority: Minor
>
> There was a recent jetty-server version bump to 
> [9.4.26.v20200117|https://mvnrepository.com/artifact/org.eclipse.jetty/jetty-server/9.4.26.v20200117],
>  that caused errors in request post-processing. Jetty version 
> [9.4.25.v20191220|https://mvnrepository.com/artifact/org.eclipse.jetty/jetty-server/9.4.25.v20191220]
>  deleted a method which was still required by the Jersey version in use. 
> That particular error did not surface in any tests because it only happens on 
> request post-processing, i.e. after the response has already been sent to the 
> client. From the test's point of view, the request behaved as expected. 
> Internally on Jetty though, post-processing crashes and is aborted. That 
> would include server bookkeeping, like freeing resources, etc. 
> It would be ideal to have a way to verify that request handling completed 
> successfully in the tests, after the response is validated.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to