[
https://issues.apache.org/jira/browse/KAFKA-9654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17051636#comment-17051636
]
ASF GitHub Bot commented on KAFKA-9654:
---------------------------------------
chia7712 commented on pull request #8223: KAFKA-9654 ReplicaAlterLogDirsThread
can't be created again if the pr…
URL: https://github.com/apache/kafka/pull/8223
ReplicaManager does create ReplicaAlterLogDirsThread only if an new future
log is created. If the previous ReplicaAlterLogDirsThread encounters error when
moving data, the target partition is moved to "failedPartitions" and
ReplicaAlterLogDirsThread get idle due to empty partitions. The future log is
still existent so we CAN'T either create another ReplicaAlterLogDirsThread to
handle the parition or update the paritions of the idler
ReplicaAlterLogDirsThread.
ReplicaManager should call
ReplicaAlterLogDirsManager#addFetcherForPartitions even if there is already a
future log since we can create an new ReplicaAlterLogDirsThread to handle the
new partitions or update the partitions of existent ReplicaAlterLogDirsThread
to make it busy again.
https://issues.apache.org/jira/browse/KAFKA-9654
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> ReplicaAlterLogDirsThread can't be created again if the previous
> ReplicaAlterLogDirsThreadmeet encounters leader epoch error
> ----------------------------------------------------------------------------------------------------------------------------
>
> Key: KAFKA-9654
> URL: https://issues.apache.org/jira/browse/KAFKA-9654
> Project: Kafka
> Issue Type: Bug
> Reporter: Chia-Ping Tsai
> Assignee: Chia-Ping Tsai
> Priority: Critical
>
> ReplicaManager does create ReplicaAlterLogDirsThread only if an new future
> log is created. If the previous ReplicaAlterLogDirsThread encounters error
> when moving data, the target partition is moved to "failedPartitions" and
> ReplicaAlterLogDirsThread get idle due to empty partitions. The future log is
> still existent so we CAN'T either create another ReplicaAlterLogDirsThread to
> handle the parition or update the paritions of the idler
> ReplicaAlterLogDirsThread.
> ReplicaManager should call ReplicaAlterLogDirsManager#addFetcherForPartitions
> even if there is already a future log since we can create an new
> ReplicaAlterLogDirsThread to handle the new partitions or update the
> partitions of existent ReplicaAlterLogDirsThread to make it busy again.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
