[
https://issues.apache.org/jira/browse/KAFKA-7787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17053686#comment-17053686
]
Tom Bentley commented on KAFKA-7787:
------------------------------------
[~cmccabe] thanks for getting back to me.
The UNKNOWN enum values are interesting as (at least for {{ConfigType}})
UNKNOWN represents a value which is never sent on the wire. So it didn't feel
especially weird to not enumerate that in the protocol. But it would be simple
enough to declare things like that in the {{codes}} declaration (and perhaps
mark it as not being part of the wire protocol, so it couldn't be used in a
{{domain}}).
I already have the sharing of enums between messages sorted by using a new top
level type, as you suggest.
For errors, I just used the constants in the existing Errors class, which is a
bit of a cheat as it has to be manually maintained. Are you aiming to generate
{{Errors}}?
I'll post a PR with the code I hacked together so you can see how it works at
this point.
> Add error specifications to KAFKA-7609
> --------------------------------------
>
> Key: KAFKA-7787
> URL: https://issues.apache.org/jira/browse/KAFKA-7787
> Project: Kafka
> Issue Type: Sub-task
> Reporter: Colin McCabe
> Assignee: Tom Bentley
> Priority: Minor
>
> In our RPC JSON, it would be nice if we could specify what versions of a
> response could contain what errors. See the discussion here:
> https://github.com/apache/kafka/pull/5893#discussion_r244841051
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
