[ 
https://issues.apache.org/jira/browse/KAFKA-9852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17081052#comment-17081052
 ] 

ASF GitHub Bot commented on KAFKA-9852:
---------------------------------------

soenkeliebau commented on pull request #8464: KAFKA-9852: Change the max 
duration that calls to the buffer pool can block from 2000ms to 10ms
URL: https://github.com/apache/kafka/pull/8464
 
 
   This is to reduce overall test runtime, as this is wallclock time.
   
   Adjusted one assert condition on a testcase as the success was dependant on 
thread runtimes and the much lower tolerances due to the reduced time broke 
this test.
   
   Ran a couple thousand iterations of the test class on my machine without 
failed test cases.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Lower block duration in BufferPoolTest to cut down on overall test runtime
> --------------------------------------------------------------------------
>
>                 Key: KAFKA-9852
>                 URL: https://issues.apache.org/jira/browse/KAFKA-9852
>             Project: Kafka
>          Issue Type: Improvement
>          Components: unit tests
>            Reporter: Sönke Liebau
>            Assignee: Sönke Liebau
>            Priority: Trivial
>
> In BufferPoolTest we use a global setting for the maximum duration that calls 
> can block (max.block.ms) of [2000ms 
> |https://github.com/apache/kafka/blob/e032a360708cec2284f714e4cae388066064d61c/clients/src/test/java/org/apache/kafka/clients/producer/internals/BufferPoolTest.java#L54]
> Since this is wall clock time that might be waited on and could potentially 
> come into play multiple times while this class is executed this is a very 
> long timeout for testing.
> We should reduce this timeout to a much lower value to cut back on test 
> runtimes.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to