ableegoldman commented on pull request #8588: URL: https://github.com/apache/kafka/pull/8588#issuecomment-622154885
Oh man, I just read my original comment again and I totally swapped the descriptions of the two cases. Hopefully you knew what I meant but I went back and fixed it just in case. I think we're in agreement on the first two scenarios, but I'm not so sure about the third (also I think you mean "under capacity" here, but I'm the one who messed this up in the first place). I might be misinterpreting you though: when you say we round-robin over the clients do you mean over _all_ the clients, or only over the clients with remaining unfulfilled quota? "Quota" meaning the number of tasks we'd give each client assuming an equal # tasks per thread across all instances, ie total_tasks * client_capacity / total_capacity. To be clear, what I was suggesting was the latter. I'll hold off on making a long argument for it in case we're already on the same page here, but to loop this back towards relevance to the current PR this would mean not verifying client-level balance in this case. I guess as you pointed out though, we'd also want to drop enforcing client-level balance in the "over+under" capacity case ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
