vvcephei commented on a change in pull request #8248:
URL: https://github.com/apache/kafka/pull/8248#discussion_r418852189
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StoreChangelogReader.java
##########
@@ -789,7 +789,7 @@ private void prepareChangelogs(final Set<ChangelogMetadata>
newPartitionsToResto
}
@Override
- public void remove(final Collection<TopicPartition> revokedChangelogs) {
+ public void unregister(final Collection<TopicPartition> revokedChangelogs)
{
Review comment:
Thanks! We just have to review this once, but maintain it "forever", so
I'm always happy to see improvements like this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
