viktorsomogyi commented on a change in pull request #8591:
URL: https://github.com/apache/kafka/pull/8591#discussion_r420040567
##########
File path: core/src/main/scala/kafka/utils/Json.scala
##########
@@ -35,16 +35,7 @@ object Json {
*/
def parseFull(input: String): Option[JsonValue] =
Review comment:
I looks like `parseFull` is used in a couple of places as Json mentioned
but I can perhaps just delegate this to `parseBytes` like this below and can
continue using that in the mentioned callers.
```
def parseFull(input: String): Option[JsonValue] =
parseBytes(input.getBytes(Charset.defaultCharset()))
```
Or shall I just get rid of this code and use `parseBytes` everywhere?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
