hachikuji commented on a change in pull request #8585: URL: https://github.com/apache/kafka/pull/8585#discussion_r421026806
########## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ########## @@ -949,8 +949,11 @@ class ReplicaManager(val config: KafkaConfig, else FetchHighWatermark - // Restrict fetching to leader if request is from follower or from a client with older version (no ClientMetadata) - val fetchOnlyFromLeader = isFromFollower || (isFromConsumer && clientMetadata.isEmpty) + // Restrict fetching to leader if request is from follower or from an ordinary consumer + // with an older version (which is implied by no ClientMetadata) Review comment: If there are any use cases which rely on it, users can upgrade their clients to regain the ability. Since no one has evidently noticed that this functionality was lost, I think it's probably fine to remove it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org