rhauch commented on a change in pull request #8620:
URL: https://github.com/apache/kafka/pull/8620#discussion_r422385330



##########
File path: 
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConfig.java
##########
@@ -400,6 +412,53 @@ public WorkerConfig(ConfigDef definition, Map<String, 
String> props) {
         logInternalConverterDeprecationWarnings(props);
     }
 
+    @Override
+    public String toString() {
+        return "Comma-separated header rules, where each header rule is of the 
form "
+                + "'[action] [header name]:[header value]' and optionally 
surrounded by double quotes "
+                + "if any part of a header rule contains a comma";
+    }
+
+    public static void validateHttpResponseHeaderConfig(String config) {

Review comment:
       Then how about making these package-level protected (as I mentioned) and 
moving the tests of these methods to `WorkerConfigTest` instead?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to