junrao commented on pull request #6915: URL: https://github.com/apache/kafka/pull/6915#issuecomment-626248856
@chia7712 : Yes, the main issue is that `Partition.tryCompleteDelayedRequests()` is called through `ReplicaManager.appendRecords()` while a group lock is held in the caller. We need to change it such that the caller of `Partition.tryCompleteDelayedRequests()` doesn't hold any group lock since it's unnecessary. I was thinking that we can split `ReplicaManager.appendRecords() `into 2 methods. The first one just appends the data to local local, potentially with the caller holding a group lock. The second one can do all the purgatory checking without the caller holding any group lock. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
