vvcephei commented on a change in pull request #8588:
URL: https://github.com/apache/kafka/pull/8588#discussion_r424822166
##########
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/TaskAssignorConvergenceTest.java
##########
@@ -236,16 +233,17 @@ public void
staticAssignmentShouldConvergeWithTheFirstAssignment() {
0,
1000L);
- final Harness harness = Harness.initializeCluster(1, 1, 1);
+ final Harness harness = Harness.initializeCluster(1, 1, 1, () -> 1);
testForConvergence(harness, configs, 1);
verifyValidAssignment(0, harness);
+ verifyBalancedAssignment(harness);
}
@Test
public void assignmentShouldConvergeAfterAddingNode() {
- final int numStatelessTasks = 15;
- final int numStatefulTasks = 13;
+ final int numStatelessTasks = 7;
Review comment:
Right, but I think there's a "3" or a "5" in there somewhere, maybe in
the other test. Anyway, my _intent_ was to make them all prime so I wouldn't
have to think to hard about whether they were all coprime. But, in reality, I
managed to screw up both.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
