ableegoldman commented on a change in pull request #8662:
URL: https://github.com/apache/kafka/pull/8662#discussion_r425314263



##########
File path: 
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java
##########
@@ -169,6 +173,9 @@ public void makeReady(final Map<String, 
InternalTopicConfig> topics) {
             log.error(timeoutAndRetryError);
             throw new StreamsException(timeoutAndRetryError);
         }
+        log.debug("Completed validating internal topics and created {}", 
newlyCreatedTopics);

Review comment:
       I think this race condition was particularly severe since we do the 
listOffsets request pretty much immediately after creating the topics, whereas 
whatever we're doing with that topic next will not be until the rebalance was 
completed.
   
   AFAIK we've never had any users report subsequent operations failing after 
the first rebalance due to not-yet-fully-created topics, but it could have just 
slipped past us




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to