ableegoldman commented on a change in pull request #8669: URL: https://github.com/apache/kafka/pull/8669#discussion_r425577094
########## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/StoreChangeLogger.java ########## @@ -1,71 +0,0 @@ -/* - * Licensed to the Apache Software Foundation (ASF) under one or more - * contributor license agreements. See the NOTICE file distributed with - * this work for additional information regarding copyright ownership. - * The ASF licenses this file to You under the Apache License, Version 2.0 - * (the "License"); you may not use this file except in compliance with - * the License. You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ -package org.apache.kafka.streams.state.internals; - -import org.apache.kafka.common.serialization.Serializer; -import org.apache.kafka.streams.processor.ProcessorContext; -import org.apache.kafka.streams.processor.internals.ProcessorStateManager; -import org.apache.kafka.streams.processor.internals.RecordCollector; -import org.apache.kafka.streams.state.StateSerdes; - -/** - * Note that the use of array-typed keys is discouraged because they result in incorrect caching behavior. - * If you intend to work on byte arrays as key, for example, you may want to wrap them with the {@code Bytes} class, - * i.e. use {@code StoreChangeLogger<Bytes, ...>} rather than {@code StoreChangeLogger<byte[], ...>}. - * - * @param <K> - * @param <V> - */ -class StoreChangeLogger<K, V> { - - private final String topic; - private final int partition; - private final ProcessorContext context; - private final RecordCollector collector; - private final Serializer<K> keySerializer; - private final Serializer<V> valueSerializer; - - StoreChangeLogger(final String storeName, - final ProcessorContext context, - final StateSerdes<K, V> serialization) { - this(storeName, context, context.taskId().partition, serialization); - } - - private StoreChangeLogger(final String storeName, - final ProcessorContext context, - final int partition, - final StateSerdes<K, V> serialization) { - topic = ProcessorStateManager.storeChangelogTopic(context.applicationId(), storeName); - this.context = context; - this.partition = partition; - this.collector = ((RecordCollector.Supplier) context).recordCollector(); - keySerializer = serialization.keySerializer(); - valueSerializer = serialization.valueSerializer(); - } - - void logChange(final K key, - final V value) { - logChange(key, value, context.timestamp()); - } - - void logChange(final K key, Review comment: This class was the root cause of the processor context issue blocking the active <--> standby task conversion. I was taking pieces out of it bit by bit and by the end it seemed pointless to have at all ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
