[ 
https://issues.apache.org/jira/browse/KAFKA-4327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17111065#comment-17111065
 ] 

Jorge Esteban Quilcate Otoya commented on KAFKA-4327:
-----------------------------------------------------

Thanks [~mjsax] . Yes, I agree this will be targeting 3.0.

Regarding, moving to tools, I was taking [~guozhang]'s idea:

> 2) thinking about it twice, leaving the reset tool in `kafka.tools` is okay 
> since it is where we put all the admin tooling classes; personally I think we 
> could also consider `o.a.k.tools`, but again that is not very significant 
> either.

Main reason I'm in favor is that I don't want to add an argument parser 
dependency to the `streams` module, if that make sense.

We could even this a more _interesting_ _change_ by considering moving _all_ 
tools to a single module `o.a.k.tools`, while applying KIP-499 and KIP-604, and 
target 3.0. WDYT?

> Move Reset Tool from core to streams
> ------------------------------------
>
>                 Key: KAFKA-4327
>                 URL: https://issues.apache.org/jira/browse/KAFKA-4327
>             Project: Kafka
>          Issue Type: Improvement
>          Components: streams
>            Reporter: Matthias J. Sax
>            Assignee: Jorge Esteban Quilcate Otoya
>            Priority: Blocker
>              Labels: needs-kip
>             Fix For: 3.0.0
>
>
> This is a follow up on https://issues.apache.org/jira/browse/KAFKA-4008
> Currently, Kafka Streams Application Reset Tool is part of {{core}} module 
> due to ZK dependency. After KIP-4 got merged, this dependency can be dropped 
> and the Reset Tool can be moved to {{streams}} module.
> This should also update {{InternalTopicManager#filterExistingTopics}} that 
> revers to ResetTool in an exception message:
> {{"Use 'kafka.tools.StreamsResetter' tool"}}
> -> {{"Use '" + kafka.tools.StreamsResetter.getClass().getName() + "' tool"}}
> Doing this JIRA also requires to update the docs with regard to broker 
> backward compatibility -- not all broker support "topic delete request" and 
> thus, the reset tool will not be backward compatible to all broker versions.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to