kkonstantine commented on a change in pull request #8699:
URL: https://github.com/apache/kafka/pull/8699#discussion_r431542321
##########
File path:
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/isolation/PluginUtilsTest.java
##########
@@ -128,6 +131,10 @@ public void testAllowedConnectFrameworkClasses() {
assertTrue(PluginUtils.shouldLoadInIsolation(
"org.apache.kafka.connect.transforms.ExtractField$Key")
);
+
assertTrue(PluginUtils.shouldLoadInIsolation("org.apache.kafka.connect.transforms.predicates."));
+ assertTrue(PluginUtils.shouldLoadInIsolation(
+
"org.apache.kafka.connect.transforms.predicates.TopicNameMatches")
+ );
Review comment:
Given the small number of predicates, I agree with @rhauch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
