hachikuji commented on a change in pull request #8238:
URL: https://github.com/apache/kafka/pull/8238#discussion_r431607959
##########
File path: clients/src/main/resources/common/message/ListGroupsRequest.json
##########
@@ -20,8 +20,14 @@
// Version 1 and 2 are the same as version 0.
//
// Version 3 is the first flexible version.
- "validVersions": "0-3",
+ //
+ // Version 4 adds the StatesFilter field (KIP-518).
+ "validVersions": "0-4",
"flexibleVersions": "3+",
"fields": [
+ { "name": "StatesFilter", "type": "[]string", "versions": "4+",
"nullableVersions": "4+", "default": "null",
Review comment:
The behavior of null is identical to an empty list in terms of
semantics. However, if an empty list is provided, the request cannot be
serialized with older versions because the field is not marked as ignorable.
Would it be simpler if we made this field non-nullable and used the default of
an empty array so that we don't have this inconsistency?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
