mjsax commented on a change in pull request #8738:
URL: https://github.com/apache/kafka/pull/8738#discussion_r432153623



##########
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##########
@@ -1246,7 +1246,7 @@ public void cleanUp() {
         }
 
         log.debug("Current changelog positions: {}", allChangelogPositions);
-        final Map<TopicPartition, ListOffsetsResultInfo> allEndOffsets = 
fetchEndOffsetsWithoutTimeout(allPartitions, adminClient);
+        final Map<TopicPartition, ListOffsetsResultInfo> allEndOffsets = 
fetchEndOffsets(allPartitions, adminClient);

Review comment:
       Can we please update the JavaDocs of `allLocalStorePartitionLags` to 
state that a `StreamsException` could be thrown?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to