mjsax commented on a change in pull request #8706:
URL: https://github.com/apache/kafka/pull/8706#discussion_r432671229
##########
File path:
streams/src/test/java/org/apache/kafka/streams/state/internals/QueryableStoreProviderTest.java
##########
@@ -88,5 +91,23 @@ public void shouldFindGlobalStores() {
assertNotNull(storeProvider.getStore(StoreQueryParameters.fromNameAndType("global",
QueryableStoreTypes.keyValueStore())));
}
+ @Test
+ public void shouldReturnKVStoreWithPartitionWhenItExists() {
+
assertNotNull(storeProvider.getStore(StoreQueryParameters.fromNameAndType(keyValueStore,
QueryableStoreTypes.keyValueStore()).withPartition(numStateStorePartitions -
1)));
Review comment:
Hmmm... Good point. Let leave it as-is. It's also covered in integration
tests that the right store is returned.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
