dajac commented on a change in pull request #8724:
URL: https://github.com/apache/kafka/pull/8724#discussion_r434361213
##########
File path: core/src/main/scala/kafka/controller/ControllerContext.scala
##########
@@ -391,6 +404,54 @@ class ControllerContext {
partitionsForTopic(topic).filter { partition =>
states.contains(partitionState(partition)) }.toSet
}
+ def putLeadershipInfo(partition: TopicPartition,
leaderIsrAndControllerEpoch: LeaderIsrAndControllerEpoch): Unit = {
+ val previous = partitionLeadershipInfo.put(partition,
leaderIsrAndControllerEpoch)
+ val replicaAssignment = partitionFullReplicaAssignment(partition)
+ updatePreferredReplicaImbalanceMetric(partition, Some(replicaAssignment),
previous,
+ Some(replicaAssignment), Some(leaderIsrAndControllerEpoch))
+ }
+
+ private def updatePreferredReplicaImbalanceMetric(partition: TopicPartition,
+ oldReplicaAssignment:
Option[ReplicaAssignment],
+ oldLeadershipInfo:
Option[LeaderIsrAndControllerEpoch],
+ newReplicaAssignment:
Option[ReplicaAssignment],
+ newLeadershipInfo:
Option[LeaderIsrAndControllerEpoch]): Unit = {
+ if (!isTopicQueuedUpForDeletion(partition.topic)) {
+ oldReplicaAssignment.foreach { replicaAssignment =>
+ oldLeadershipInfo.foreach { leadershipInfo =>
+ if (isReplicaImbalance(replicaAssignment, leadershipInfo))
+ preferredReplicaImbalanceCount -= 1
+ }
+ }
+
+ newReplicaAssignment.foreach { replicaAssignment =>
+ newLeadershipInfo.foreach { leadershipInfo =>
+ if (isReplicaImbalance(replicaAssignment, leadershipInfo))
+ preferredReplicaImbalanceCount += 1
+ }
+ }
+ }
+ }
+
+ private def cleanPreferredReplicaImbalanceMetric(topic: String): Unit = {
+ partitionAssignments.getOrElse(topic, mutable.Map.empty).foreach { case
(partition, replicaAssignment) =>
+ partitionLeadershipInfo.get(new TopicPartition(topic,
partition)).foreach { leadershipInfo =>
+ if (isReplicaImbalance(replicaAssignment, leadershipInfo))
+ preferredReplicaImbalanceCount -= 1
+ }
+ }
+ }
+
+ private def isReplicaImbalance(replicaAssignment: ReplicaAssignment,
+ leadershipInfo: LeaderIsrAndControllerEpoch):
Boolean = {
+ val preferredReplica = replicaAssignment.replicas.head
+ if (replicaAssignment.isBeingReassigned &&
replicaAssignment.addingReplicas.contains(preferredReplica))
+ // reassigning partitions are not counted as imbalanced until the new
replica joins the ISR (completes reassignment)
Review comment:
I agree with you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
