mimaison commented on a change in pull request #8311:
URL: https://github.com/apache/kafka/pull/8311#discussion_r435243287
##########
File path:
clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java
##########
@@ -570,6 +592,27 @@ public void testDeleteTopics() throws Exception {
}
}
+ @Test
+ public void testDeleteTopicsPartialResponse() throws Exception {
+ try (AdminClientUnitTestEnv env = mockClientEnv()) {
+ env.kafkaClient().setNodeApiVersions(NodeApiVersions.create());
+
+ env.kafkaClient().prepareResponse(body -> body instanceof
DeleteTopicsRequest,
+ prepareDeleteTopicsResponse("myTopic", Errors.NONE));
+ Map<String, KafkaFuture<Void>> values =
env.adminClient().deleteTopics(asList("myTopic", "myOtherTopic"),
+ new DeleteTopicsOptions()).values();
+ values.get("myTopic").get();
+
+ try {
Review comment:
We can use `TestUtils.assertFutureThrows()` here too
##########
File path:
clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java
##########
@@ -3382,6 +3425,90 @@ public void testAlterClientQuotas() throws Exception {
}
}
+ @Test
+ public void testAlterReplicaLogDirsSuccess() throws Exception {
+ try (AdminClientUnitTestEnv env = mockClientEnv()) {
+ createAlterLogDirsResponse(env, env.cluster().nodeById(0),
Errors.NONE, 0);
+ createAlterLogDirsResponse(env, env.cluster().nodeById(1),
Errors.NONE, 0);
+
+ TopicPartitionReplica tpr0 = new TopicPartitionReplica("topic", 0,
0);
+ TopicPartitionReplica tpr1 = new TopicPartitionReplica("topic", 0,
1);
+
+ Map<TopicPartitionReplica, String> logDirs = new HashMap<>();
+ logDirs.put(tpr0, "/data0");
+ logDirs.put(tpr1, "/data1");
+ AlterReplicaLogDirsResult result =
env.adminClient().alterReplicaLogDirs(logDirs);
+ assertNull(result.values().get(tpr0).get());
+ assertNull(result.values().get(tpr1).get());
+ }
+ }
+
+ @Test
+ public void testAlterReplicaLogDirsLogDirNotFound() throws Exception {
+ try (AdminClientUnitTestEnv env = mockClientEnv()) {
+ createAlterLogDirsResponse(env, env.cluster().nodeById(0),
Errors.NONE, 0);
+ createAlterLogDirsResponse(env, env.cluster().nodeById(1),
Errors.LOG_DIR_NOT_FOUND, 0);
+
+ TopicPartitionReplica tpr0 = new TopicPartitionReplica("topic", 0,
0);
+ TopicPartitionReplica tpr1 = new TopicPartitionReplica("topic", 0,
1);
+
+ Map<TopicPartitionReplica, String> logDirs = new HashMap<>();
+ logDirs.put(tpr0, "/data0");
+ logDirs.put(tpr1, "/data1");
+ AlterReplicaLogDirsResult result =
env.adminClient().alterReplicaLogDirs(logDirs);
+ assertNull(result.values().get(tpr0).get());
+ TestUtils.assertFutureError(result.values().get(tpr1),
LogDirNotFoundException.class);
+ }
+ }
+
+ @Test
+ public void testAlterReplicaLogDirsUnrequested() throws Exception {
+ try (AdminClientUnitTestEnv env = mockClientEnv()) {
+ createAlterLogDirsResponse(env, env.cluster().nodeById(0),
Errors.NONE, 1, 2);
+
+ TopicPartitionReplica tpr1 = new TopicPartitionReplica("topic", 1,
0);
+
+ Map<TopicPartitionReplica, String> logDirs = new HashMap<>();
+ logDirs.put(tpr1, "/data1");
+ AlterReplicaLogDirsResult result =
env.adminClient().alterReplicaLogDirs(logDirs);
+ assertNull(result.values().get(tpr1).get());
+ }
+ }
+
+ @Test
+ public void testAlterReplicaLogDirsPartialResponse() throws Exception {
+ try (AdminClientUnitTestEnv env = mockClientEnv()) {
+ createAlterLogDirsResponse(env, env.cluster().nodeById(0),
Errors.NONE, 1);
+
+ TopicPartitionReplica tpr1 = new TopicPartitionReplica("topic", 1,
0);
+ TopicPartitionReplica tpr2 = new TopicPartitionReplica("topic", 2,
0);
+
+ Map<TopicPartitionReplica, String> logDirs = new HashMap<>();
+ logDirs.put(tpr1, "/data1");
+ logDirs.put(tpr2, "/data1");
+ AlterReplicaLogDirsResult result =
env.adminClient().alterReplicaLogDirs(logDirs);
+ assertNull(result.values().get(tpr1).get());
+ try {
Review comment:
we can use `TestUtils.assertFutureThrows()` here too
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
