chia7712 commented on a change in pull request #8806:
URL: https://github.com/apache/kafka/pull/8806#discussion_r435739827
##########
File path:
clients/src/main/java/org/apache/kafka/common/security/ssl/SslFactory.java
##########
@@ -109,21 +112,31 @@ public void configure(Map<String, ?> configs) throws
KafkaException {
@Override
public void validateReconfiguration(Map<String, ?> newConfigs) {
- createNewSslEngineFactory(newConfigs);
+ Utils.closeQuietly(mayCreateNewSslEngineFactory(newConfigs), "close
temporary ssl engine factory");
Review comment:
It seems to me that creating an new ssl engine factory to validate
reconfiguration is a bit weird but it should be addressed by another issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
