bellemare commented on a change in pull request #8764:
URL: https://github.com/apache/kafka/pull/8764#discussion_r435886441
##########
File path:
streams/src/test/java/org/apache/kafka/streams/integration/KTableKTableForeignKeyJoinMaterializationIntegrationTest.java
##########
@@ -94,15 +101,49 @@ public void before() {
);
}
+ @Test
+ public void shouldEmitRecordWhenJoiningWithDefaultSerdes() {
Review comment:
@vvcephei Just getting back to this now. Before I rework
KTableKTableForeignKeyJoinScenarioTest:
I can keep it simple and try something like:
KTable<String, Long> aTable
KTable<Long, Integer> bTable
Or I can go ahead and use the JSONSerde, User, and Foo classes. I think the
former will suffice for coverage purposes, but I like the latter because it may
better reflect real-life use-cases (and I usually look to the tests myself to
show me how to use a function). Thoughts on this before I refactor?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
