[ https://issues.apache.org/jira/browse/KAFKA-10101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17126765#comment-17126765 ]
Ismael Juma commented on KAFKA-10101: ------------------------------------- [~junrao] That's a good point. I agree with you that it's probably simplest to remove the code that changes the recover point. The previous code had: {code:java} if(hasCleanShutdownFile) { this.recoveryPoint = activeSegment.nextOffset() return }{code} It has since been consolidated into the same path. We can probably keep that. I'll submit a PR. > recovery point is advanced without flushing the data after recovery > ------------------------------------------------------------------- > > Key: KAFKA-10101 > URL: https://issues.apache.org/jira/browse/KAFKA-10101 > Project: Kafka > Issue Type: Bug > Components: core > Affects Versions: 2.5.0 > Reporter: Jun Rao > Assignee: Ismael Juma > Priority: Major > > Currently, in Log.recoverLog(), we set recoveryPoint to logEndOffset after > recovering the log segment. However, we don't flush the log segments after > recovery. The potential issue is that if the broker has another hard failure, > segments may be corrupted on disk but won't be going through recovery on > another restart. > This logic was introduced in KAFKA-5829 since 1.0.0. -- This message was sent by Atlassian Jira (v8.3.4#803005)