vvcephei commented on a change in pull request #8818:
URL: https://github.com/apache/kafka/pull/8818#discussion_r436205286



##########
File path: 
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java
##########
@@ -1084,12 +1088,15 @@ private boolean 
populateActiveTaskAndPartitionsLists(final List<TopicPartition>
                 // If the partition is new to this consumer but is still owned 
by another, remove from the assignment
                 // until it has been revoked and can safely be reassigned 
according to the COOPERATIVE protocol
                 if (newPartitionForConsumer && 
allOwnedPartitions.contains(partition)) {
-                    log.info("Removing task {} from assignment until it is 
safely revoked in followup rebalance", taskId);
-                    clientState.unassignActive(taskId);

Review comment:
       By the way, this tripped me up quite a bit. Changing the clientState has 
absolutely no effect at this point. Might be nice to enforce that in code, but 
I'd like to defer it (I took a stab, but it's a lot of changes).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to