[ 
https://issues.apache.org/jira/browse/KAFKA-10126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17129604#comment-17129604
 ] 

Chia-Ping Tsai commented on KAFKA-10126:
----------------------------------------

> What's about numFetchersOpt? Can it be removed?

I grep the code and both of numThreadsOpt and numFetchersOpt are indeed unused. 
Removing them should be fine as it does not break the compatibility. However, I 
prefer to make them work again.

> It seems that the topic could be created by the producer or kafka-topics.sh. 
> So is it proper to add new arguments to create topic ?

If you have a KIP to explain the purpose of new arguments, it is ok to add new 
arguments/behavior to ConsumerPerformance. At any rate, this can be discussed 
in another issue.

> Remove unused options in ConsumerPerformance
> --------------------------------------------
>
>                 Key: KAFKA-10126
>                 URL: https://issues.apache.org/jira/browse/KAFKA-10126
>             Project: Kafka
>          Issue Type: Bug
>            Reporter: jiamei xie
>            Assignee: jiamei xie
>            Priority: Major
>
> Option numThreadsOpt and numFetchersOpt are unused in ConsumerPerformance. 
> It's a waste of time to test performance vs threads number. So removing it is 
> needed.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to