kkonstantine commented on a change in pull request #8453:
URL: https://github.com/apache/kafka/pull/8453#discussion_r437612063
##########
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignor.java
##########
@@ -229,6 +229,10 @@ private Long ensureLeaderConfig(long maxOffset,
WorkerCoordinator coordinator) {
Map<String, ConnectorsAndTasks> toRevoke = computeDeleted(deleted,
connectorAssignments, taskAssignments);
log.debug("Connector and task to delete assignments: {}", toRevoke);
+ // It may cause some duplicated assignment, when a worker with old
generation assignment re-join the group
Review comment:
The comment is a bit unclear. This code is not causing the duplicated
assignment. Is resolving it by revoking redundant tasks. Can we rephrase?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
