abbccdda commented on a change in pull request #8843:
URL: https://github.com/apache/kafka/pull/8843#discussion_r437858956
##########
File path:
streams/src/test/java/org/apache/kafka/streams/integration/KTableSourceTopicRestartIntegrationTest.java
##########
@@ -107,7 +109,6 @@ public void before() {
@After
public void after() throws Exception {
IntegrationTestUtils.purgeLocalStreamsState(STREAMS_CONFIG);
- CLUSTER.deleteAllTopicsAndWait(60000L);
Review comment:
Does the deletion logic affect the success of each test? If not, I would
prefer to keep it to simplify the broker side log for each subsequent tests,
such that we don't have a lot of unused topics.
##########
File path:
streams/src/test/java/org/apache/kafka/streams/integration/KTableSourceTopicRestartIntegrationTest.java
##########
@@ -236,11 +237,7 @@ public void onRestoreStart(final TopicPartition
topicPartition,
final String storeName,
final long startingOffset,
final long endingOffset) {
- try {
Review comment:
The original logic seems unnecessary?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
