ableegoldman commented on a change in pull request #8856:
URL: https://github.com/apache/kafka/pull/8856#discussion_r439550755
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java
##########
@@ -528,7 +521,8 @@ private void maybeScheduleCheckpoint() {
private void writeCheckpointIfNeed() {
if (commitNeeded) {
- throw new IllegalStateException("A checkpoint should only be
written if no commit is needed.");
+ throw new IllegalStateException("A checkpoint should only be
written if the previous commit has completed"
+ + " and there is no new commit
needed.");
Review comment:
I'll revert it to the original and add a error log message: does
```log.error("Tried to write a checkpoint with pending uncommitted data,
should complete the commit first.");```
make sense to you?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
