tombentley commented on pull request #8808:
URL: https://github.com/apache/kafka/pull/8808#issuecomment-644211634


   @dajac the problem happens when `--command-config` is given on the command 
line, and the config file defines a `client.id`. The `AppInfoParser` tries to 
register an MBean whose name is the same as the name used by the existing admin 
client instance, and the platform MBean server throws the exception given in 
the issue. Sorry, the initial description in 
[KAFKA-10109](https://issues.apache.org/jira/browse/KAFKA-10109) omitted this 
important detail (now fixed).
   
   Your point about false positives when verifying the output is correct, 
that's because it's currently not verifying the output, only the logging. To 
catch this error by verifying the standard output of the command alone would 
require changing the `log4j.properties` for all tests in core, which I felt was 
probably not warranted for this bug alone: I assume they've been set at `ERROR` 
for a more important reason. Or are you suggesting we use both 
`grabConsoleOutput()` and `LogCaptureAppender`?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to