[GitHub] [kafka] abbccdda commented on a change in pull request #8876: KAFKA-10167: use the admin client to read end-offset 【WIP】

[GitBox]

abbccdda commented on a change in pull request #8876:
URL: https://github.com/apache/kafka/pull/8876#discussion_r440545343



##########
File path: 
streams/src/main/java/org/apache/kafka/streams/processor/internals/StoreChangelogReader.java
##########
@@ -199,12 +204,19 @@ int bufferedLimitIndex() {
     // to update offset limit for standby tasks;
     private Consumer<byte[], byte[]> mainConsumer;
 
+    // the changelog reader needs the admin client to list end offsets
+    private Admin adminClient;
+
     private long lastUpdateOffsetTime;
 
     void setMainConsumer(final Consumer<byte[], byte[]> consumer) {
         this.mainConsumer = consumer;
     }
 
+    void setAdminClient(final Admin adminClient) {

Review comment:
       This is not used.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org