mjsax commented on a change in pull request #8886:
URL: https://github.com/apache/kafka/pull/8886#discussion_r441812617
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StandbyTask.java
##########
@@ -85,6 +85,21 @@ public void initializeMetadata() {}
public boolean initializeStateStores() {
log.trace("Initializing state stores");
registerStateStores();
+
+ if (eosEnabled) {
Review comment:
That is the tradeoff people buy in when using at-least-once. As long as
state store recovery is expensive, it's not worth to change it IMHO. Also note,
even if we wipe out the store for non-eos, the corrupted record might have been
written into the changelog topic already, and thus, we would recover the
corrupted state again, not gaining anything.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
