hachikuji commented on a change in pull request #8850:
URL: https://github.com/apache/kafka/pull/8850#discussion_r441930200
##########
File path: core/src/main/scala/kafka/log/Log.scala
##########
@@ -1794,20 +1811,30 @@ class Log(@volatile private var _dir: File,
def shouldDelete(segment: LogSegment, nextSegmentOpt: Option[LogSegment])
= {
if (diff - segment.size >= 0) {
diff -= segment.size
+ info(s"Segment with base offset ${segment.baseOffset} will be deleted
due to" +
+ s" ${config.retentionSize} breach. Segment size is ${segment.size}
and total log size" +
Review comment:
nit: ".. will be deleted due to **retention size in bytes**
${config.retentionSize} breach."
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
