dajac commented on a change in pull request #8672:
URL: https://github.com/apache/kafka/pull/8672#discussion_r446190937
##########
File path: core/src/main/scala/kafka/cluster/Partition.scala
##########
@@ -459,7 +459,12 @@ class Partition(val topicPartition: TopicPartition,
}
}
- def delete(): Unit = {
+ /**
+ * Delete the partition. The underlying logs are deleted by default but one
can choose to not
+ * delete them automatically and to delete them manually later one. For
instance, we do this
+ * in the handling of the StopReplicaRequest to batch the deletions and
checkpoint only once.
+ */
+ def delete(deleteLogs: Boolean = true): Unit = {
Review comment:
Yes, we can.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
