C0urante commented on a change in pull request #8910:
URL: https://github.com/apache/kafka/pull/8910#discussion_r447162953
##########
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSinkTask.java
##########
@@ -138,6 +139,7 @@ public WorkerSinkTask(ConnectorTaskId id,
this.sinkTaskMetricsGroup.recordOffsetSequenceNumber(commitSeqno);
this.consumer = consumer;
this.isTopicTrackingEnabled =
workerConfig.getBoolean(TOPIC_TRACKING_ENABLE_CONFIG);
+ this.taskStopped = false;
Review comment:
Given the complexity of the unit tests for the `WorkerSinkTask` class
and the guarantees we get from the coverage of the existing tests, I'm not sure
it's really worth the effort. The code path that's modified in this PR is
agnostic about the cause of shutdown for the task and we won't really get any
more coverage by simulating a shutdown triggered by an exception from the
`SinkTask` instance instead of external request from the `Worker` instance.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
