guozhangwang commented on a change in pull request #8963:
URL: https://github.com/apache/kafka/pull/8963#discussion_r449798211
##########
File path:
streams/src/test/java/org/apache/kafka/streams/integration/EosBetaUpgradeIntegrationTest.java
##########
@@ -837,6 +866,11 @@ public void init(final ProcessorContext context) {
crash = errorInjectedClient2;
sharedCommit = commitCounterClient2;
}
+ punctuator = context.schedule(
Review comment:
In this test we would have multiple punctuator indeed but they would be
executed by a single thread sequentially so that's fine.
##########
File path:
streams/src/test/java/org/apache/kafka/streams/integration/utils/IntegrationTestUtils.java
##########
@@ -1273,7 +1273,7 @@ public void prepareForRebalance() {
*/
public void waitForNextStableAssignment(final long maxWaitMs) throws
InterruptedException {
waitForCondition(
- () -> nextExpectedNumStableAssignments ==
numStableAssignments(),
+ () -> numStableAssignments() >=
nextExpectedNumStableAssignments,
Review comment:
Makes sense to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
