ijuma commented on a change in pull request #8990:
URL: https://github.com/apache/kafka/pull/8990#discussion_r451059876
##########
File path:
clients/src/main/java/org/apache/kafka/clients/ClusterConnectionStates.java
##########
@@ -440,6 +442,16 @@ public boolean isConnectionSetupTimeout(String id, long
now) {
return now - lastConnectAttemptMs(id) > connectionSetupTimeoutMs(id);
}
+ /**
+ * Return the Set of nodes whose connection setup has timed out.
+ * @param now the current time in ms
+ */
+ public Set<String> nodesWithConnectionSetupTimeout(long now) {
Review comment:
Do we need a `Set` here? Not sure we need to pay the cost of creating
the `HashSet`, etc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
