ableegoldman commented on a change in pull request #8996:
URL: https://github.com/apache/kafka/pull/8996#discussion_r452372357
##########
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/ProcessorStateManagerTest.java
##########
@@ -784,7 +784,7 @@ public void close() {
}
@Test
- public void shouldThrowTaskCorruptedWithoutCheckpointNonEmptyDir() throws
IOException {
+ public void
shouldThrowTaskCorruptedWithoutPersistentStoreCheckpointAndNonEmptyDir() throws
IOException {
final long checkpointOffset = 10L;
final Map<TopicPartition, Long> offsets = mkMap(
Review comment:
Sorry yeah the relevant part doesn't show up on github. Basically we
register
```
stateMgr.registerStore(persistentStore,
persistentStore.stateRestoreCallback);
stateMgr.registerStore(persistentStoreTwo,
persistentStoreTwo.stateRestoreCallback);
stateMgr.registerStore(nonPersistentStore,
nonPersistentStore.stateRestoreCallback);
```
but only write the checkpoint for the `persistentStorePartition`,
nonPersistentStorePartition` and `irrelevantPartition`. I think the point of
the `irrelevantPartition` is to make sure that we detect that the
`persistentStoreTwoPartition` offset is missing even though the checkpoint
technically has the correct number of offsets in total. ie, that we actually
map the offsets to a registered changelog
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
