ableegoldman commented on a change in pull request #8994:
URL: https://github.com/apache/kafka/pull/8994#discussion_r453073305
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java
##########
@@ -95,7 +96,7 @@
* | | Assigned (3)| <----+
* | +-----+-------+ |
* | | |
- * | | |
+ * | |--------------+
Review comment:
FWIW, we actually do follow this pattern already, at least with respect
to StreamThread state transitions. I'd rather be consistent with the other
StreamThread state changes and inconsistent with other places in the code (eg
the Task state changes), especially if we all agree this seems like the
sensible approach to the fsm
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
